Show only 2 other tutorials in last step of each tutorial.#2729
Merged
paulkaplan merged 1 commit intoscratchfoundation:developfrom Jul 30, 2018
Merged
Show only 2 other tutorials in last step of each tutorial.#2729paulkaplan merged 1 commit intoscratchfoundation:developfrom
paulkaplan merged 1 commit intoscratchfoundation:developfrom
Conversation
Enforce this by using `slice` so that no more are ever shown, which would mess up the layout. Also fixes the issue where the card text could push out when translated into other languages
rschamp
approved these changes
Jul 30, 2018
Contributor
|
Looks good to me! Thanks for making this change @paulkaplan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce this by using
sliceso that no more are ever shown, which would mess up the layout.Also fixes the issue where the card text could push out when translated into other languages
Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
Describe what this Pull Request does
Make the deck preview wider and more padded out from the edges. Also enforce a max width to force titles to wrap.